[cassandra] Blacklisting/Whitelisting Tags for Indexing #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
|
At scale the canary ingester is using roughly the same CPU and indexing significantly less tags
|
|
Manually confirmed in our environment that blacklisted tags are not being indexed and other tags are. Removing draft. |
joe-elliott
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1904 +/- ##
==========================================
+ Coverage 98.42% 98.45% +0.03%
==========================================
Files 197 198 +1
Lines 9648 9706 +58
==========================================
+ Hits 9496 9556 +60
+ Misses 116 114 -2
Partials 36 36
Continue to review full report at Codecov.
|
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
yurishkuro
reviewed
Nov 8, 2019
Signed-off-by: Joe Elliott <[email protected]>
joe-elliott
force-pushed
the
tag-filter
branch
from
e49d451
to
9726f1f
Compare
yurishkuro
reviewed
Nov 8, 2019
plugin/storage/cassandra/spanstore/dbmodel/tag_filter_blacklist.go
Outdated
Show resolved
Hide resolved
plugin/storage/cassandra/spanstore/dbmodel/tag_filter_whitelist.go
Outdated
Show resolved
Hide resolved
plugin/storage/cassandra/spanstore/dbmodel/tag_filter_blacklist.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
yurishkuro
reviewed
Nov 8, 2019
plugin/storage/cassandra/spanstore/dbmodel/tag_filter_exact_match.go
Outdated
Show resolved
Hide resolved
plugin/storage/cassandra/spanstore/dbmodel/tag_filter_exact_match_test.go
Outdated
Show resolved
Hide resolved
|
Please make sure the description says |
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
yurishkuro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
tag-index-blacklist,tag-index-whitelist