Revert latest gRPC changes to allow more flexibility in versions #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon and
vprithvi
as code owners
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
changed the title
vprithvi
approved these changes
Jan 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #2018 +/- ##
==========================================
- Coverage 97.45% 97.41% -0.04%
==========================================
Files 207 207
Lines 10243 10243
==========================================
- Hits 9982 9978 -4
- Misses 220 222 +2
- Partials 41 43 +2
Continue to review full report at Codecov.
|
yurishkuro
pushed a commit
to yurishkuro/jaeger
that referenced
this pull request
Feb 18, 2020
…ons (jaegertracing#2018)" This reverts commit f605a34. Signed-off-by: Yuri Shkuro <[email protected]>
Merged
yurishkuro
added a commit
that referenced
this pull request
Feb 19, 2020
* Revert "Revert latest gRPC changes to allow more flexibility in versions (#2018)" This reverts commit f605a34. Signed-off-by: Yuri Shkuro <[email protected]> * bump Signed-off-by: Yuri Shkuro <[email protected]> * bump Signed-off-by: Yuri Shkuro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
resolver.BuildOptiontoresolver.BuildOptions, and created deprecated aliases.dep ensure --update#2012 changed the code to remove deprecation failures from staticcheckShort description of the changes
lint:ignorecomments to pass staticcheck