Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ppc64le support #2293

Merged
merged 3 commits into from
Jun 19, 2020
Merged

Add ppc64le support #2293

merged 3 commits into from
Jun 19, 2020

Conversation

svghadi
Copy link
Contributor

@svghadi svghadi commented Jun 16, 2020

Signed-off-by: Siddhesh Ghadi [email protected]

Which problem is this PR solving?

Short description of the changes

  • Adds ppc64le support for binaries & runs unit test on ppc64le architecture on travis-ci

@svghadi svghadi requested a review from a team as a code owner June 16, 2020 15:26
@svghadi svghadi requested a review from pavolloffay June 16, 2020 15:26
Copy link
Member

@pavolloffay pavolloffay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single comment otherwise it looks good to me.

.travis.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #2293 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2293      +/-   ##
==========================================
- Coverage   96.22%   96.21%   -0.02%     
==========================================
  Files         218      218              
  Lines       10687    10692       +5     
==========================================
+ Hits        10284    10287       +3     
- Misses        348      350       +2     
  Partials       55       55              
Impacted Files Coverage Δ
plugin/storage/es/options.go 100.00% <100.00%> (ø)
cmd/query/app/server.go 92.20% <0.00%> (-2.60%) ⬇️
...lugin/sampling/strategystore/adaptive/processor.go 99.20% <0.00%> (-0.80%) ⬇️
cmd/query/app/static_handler.go 85.83% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b46738c...993fdab. Read the comment docs.

Signed-off-by: Siddhesh Ghadi <[email protected]>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yurishkuro yurishkuro merged commit 3bedc5a into jaegertracing:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ppc64le architecture build
3 participants