Use queue retry per exporter

[pavolloffay]

Signed-off-by: Pavol Loffay [email protected]

This PR configures queue retry per exporter and removes the qretry form the default configuration. This is a prefered configuration since the global qretry would retry all exporters in the pipeline. See example ocnfig from OTEL https://github.com/open-telemetry/opentelemetry-collector/blob/master/exporter/otlpexporter/config.go#L26.

Other notable changes:

• qretry is not defined for in-memory and kafka (we will swith to OTEL kafka impl soon)

[pavolloffay]

@joe-elliott would you like to review?

[codecov]

Codecov Report

Merging #2444 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2444   +/-   ##
=======================================
  Coverage   95.58%   95.59%           
=======================================
  Files         208      208           
  Lines       10681    10681           
=======================================
+ Hits        10209    10210    +1     
+ Misses        400      399    -1     
  Partials       72       72           

Impacted Files	Coverage Δ
plugin/storage/integration/integration.go	80.86% <0.00%> (+0.47%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc580bb...2f3d9f0. Read the comment docs.

[joe-elliott]

Looks good to me. Two questions:

• In several places you note // TODO: Enable the queued settings by default.. Why not just leave the defaults alone and enable it now?
• Why not add this to the jaegerexporter? It seems like we'd want queueing and retries from agent -> collector

[pavolloffay]

Why not add this to the jaegerexporter? It seems like we'd want queueing and retries from agent -> collector

It already supports qretry, we just wrapping it and adding support for flags.

[pavolloffay]

In several places you note // TODO: Enable the queued settings by default.. Why not just leave the defaults alone and enable it now?

It is from https://github.com/open-telemetry/opentelemetry-collector/pull/1401/files#r457838535. I have created issue to track it open-telemetry/opentelemetry-collector#1721

I think we can enable it by default since it will be enabled anyways.