Remove olivere elastic client from OTEL #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
|
cc) @joe-elliott :) |
Signed-off-by: Pavol Loffay <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2448 +/- ##
=======================================
Coverage 95.56% 95.56%
=======================================
Files 208 208
Lines 10679 10679
=======================================
Hits 10205 10205
Misses 402 402
Partials 72 72 Continue to review full report at Codecov.
|
annanay25
approved these changes
Sep 2, 2020
| @@ -19,5 +18,5 @@ require ( | |||
| github.com/uber/jaeger-client-go v2.23.1+incompatible | |||
| github.com/uber/jaeger-lib v2.2.0+incompatible | |||
| go.opentelemetry.io/collector v0.8.1-0.20200820012544-1e65674799c8 | |||
| go.uber.org/zap v1.15.0 | |||
| go.uber.org/zap v1.16.0 | |||
There was a problem hiding this comment.
Can you rebase? This change has been merged into master.
There was a problem hiding this comment.
This is OK here, that PR should have changed the version also here.
albertteoh
pushed a commit
to albertteoh/jaeger
that referenced
this pull request
Sep 3, 2020
* Remove olivere elastic client from OTEL Signed-off-by: Pavol Loffay <[email protected]> * Do not initialize after cleanup, use 1shard 0rep Signed-off-by: Pavol Loffay <[email protected]> Signed-off-by: albertteoh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay [email protected]
This should completely remove dependency on olivere client from OTEL. It's not needed as we use only the elastic.co client.