Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate OTEL instrumentation library to ES DB model #2484

Merged
merged 3 commits into from
Sep 17, 2020

Conversation

pavolloffay
Copy link
Member

Signed-off-by: Pavol Loffay [email protected]

@objectiser
Copy link
Contributor

objectiser commented Sep 17, 2020

@pavolloffay otel crossdock seems to be failing. Restarted.

@pavolloffay
Copy link
Member Author

It seems to be a regression there I have also restarted it, I am going to investigate it.

@pavolloffay
Copy link
Member Author

Weird, locally it passes (but I had to remove go service due to DNS issues on my host)

Signed-off-by: Pavol Loffay <[email protected]>
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #2484 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2484      +/-   ##
==========================================
+ Coverage   95.50%   95.52%   +0.02%     
==========================================
  Files         208      208              
  Lines       10759    10759              
==========================================
+ Hits        10275    10278       +3     
+ Misses        408      405       -3     
  Partials       76       76              
Impacted Files Coverage Δ
plugin/storage/integration/integration.go 81.39% <0.00%> (+0.46%) ⬆️
...lugin/sampling/strategystore/adaptive/processor.go 100.00% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8604c63...f97c127. Read the comment docs.

@pavolloffay pavolloffay merged commit 4dd57f3 into jaegertracing:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants