Use fossa-contrib/fossa-action instead #2571

smorimoto · 2020-10-15T20:51:11Z

Which problem is this PR solving?

None

Short description of the changes

By using dedicated Action, you can keep your workflow simple and gain some benefits.

codecov · 2020-10-15T21:30:25Z

Codecov Report

Merging #2571 (3c241fe) into master (72b9a06) will increase coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2571      +/-   ##
==========================================
+ Coverage   95.06%   95.31%   +0.24%     
==========================================
  Files         210      208       -2     
  Lines        9410     9281     -129     
==========================================
- Hits         8946     8846     -100     
+ Misses        387      357      -30     
- Partials       77       78       +1

Impacted Files	Coverage Δ
cmd/collector/app/collector.go	`69.44% <0.00%> (-4.85%)`	⬇️
...lugin/sampling/strategystore/adaptive/processor.go	`99.07% <0.00%> (-0.93%)`	⬇️
plugin/storage/integration/integration.go	`77.34% <0.00%> (-0.56%)`	⬇️
pkg/config/tlscfg/cert_watcher.go	`94.44% <0.00%> (-0.37%)`	⬇️
pkg/testutils/logger.go	`100.00% <0.00%> (ø)`
cmd/collector/app/zipkin/jsonv2.go	`100.00% <0.00%> (ø)`
cmd/ingester/app/consumer/consumer.go	`100.00% <0.00%> (ø)`
cmd/ingester/app/consumer/deadlock_detector.go	`100.00% <0.00%> (ø)`
cmd/anonymizer/app/anonymizer/anonymizer.go
cmd/anonymizer/app/flags.go
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72b9a06...cd90c16. Read the comment docs.

Signed-off-by: Sora Morimoto <[email protected]>

yurishkuro · 2020-10-15T23:15:06Z

.github/workflows/fossa.yml

+        run: echo "GOPATH=$(go env GOPATH)" >>"$GITHUB_ENV"
+
+      - name: Add GOPATH to GITHUB_PATH
+        run: echo "$GOPATH/bin" >>"$GITHUB_PATH"


?

Do these GITHUB_ENV/GITHUB_PATH vars contain file names?

Is this probably what you are looking for?
https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#environment-files

It's also not clear to me why this is needed. Perhaps leave a comment in the code?

Well, all it does is expose the GOPATH environment variable and add GOPATH to the PATH. Of course, we can do it more typically. Or are you asking why these are necessary? If so, it's necessary because fossa-cli needs them when it analyzes.

yurishkuro · 2020-10-15T23:18:41Z

.github/workflows/fossa.yml

+        run: echo "$GOPATH/bin" >>"$GITHUB_PATH"
+
+      - name: Run FOSSA scan and upload build data
+        uses: fossa-contrib/fossa-action@v1


Why isn't this an official action under github.com/fossas ?

Because this isn't an official action yet.

jpkrohling · 2020-10-27T20:13:27Z

@Mergifyio rebase

mergify · 2020-10-27T20:14:00Z

Command rebase: action_required

Pull request must be rebased manually.
GitHub App like Mergify are not allowed to rebase pull request where .github/workflows is changed.

jpkrohling

The check seems to work, but just need a clarification on the "Add GOPATH" steps.

jpkrohling · 2020-10-27T20:15:30Z

.github/workflows/fossa.yml

+        run: echo "GOPATH=$(go env GOPATH)" >>"$GITHUB_ENV"
+
+      - name: Add GOPATH to GITHUB_PATH
+        run: echo "$GOPATH/bin" >>"$GITHUB_PATH"


It's also not clear to me why this is needed. Perhaps leave a comment in the code?

jpkrohling · 2020-11-05T08:39:27Z

@smorimoto, are you still interested in this one?

smorimoto · 2020-11-05T17:45:45Z

Oh, I'm sorry I missed it.

yurishkuro · 2020-11-17T17:33:02Z

Thanks!

* Use fossa-contrib/fossa-action instead Signed-off-by: Sora Morimoto <[email protected]> * Make step name clearer Signed-off-by: Sora Morimoto <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>

* Bump opentelemetry-collector to v0.14.0 (jaegertracing#2617) * bump opentelemetry-collector to v0.14.0 Signed-off-by: Pavel Kositsyn <[email protected]> * initialize traceid and spanid explicitly Signed-off-by: Pavel Kositsyn <[email protected]> * fix comments and empty parent span check Signed-off-by: Pavel Kositsyn <[email protected]> * fasten convert traceID/spanID Signed-off-by: Pavel Kositsyn <[email protected]> * fix convertTraceID + fix tests Signed-off-by: Pavel Kositsyn <[email protected]> * Update CodeQL to latest best practices (jaegertracing#2615) This will parallelize your analysis and speed things up a bunch. Signed-off-by: jhutchings1 <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]> * Fix flaky TestReload (jaegertracing#2624) Signed-off-by: albertteoh <[email protected]> * Update x/text to v0.3.4 (jaegertracing#2625) Signed-off-by: Gary Brown <[email protected]> * Bump to latest UI for snapshot builds (jaegertracing#2626) Signed-off-by: Yuri Shkuro <[email protected]> * Implement anonymizer's main program (jaegertracing#2621) * Preparing release 1.21.0 (jaegertracing#2630) * updated changelog Signed-off-by: Joe Elliott <[email protected]> * Added ui changelog Signed-off-by: Joe Elliott <[email protected]> * Fixed UI changelog to point to 1.12.0 Signed-off-by: Joe Elliott <[email protected]> * Updated jaeger-ui to v1.12.0 Signed-off-by: Joe Elliott <[email protected]> * Resolving concerns Signed-off-by: Joe Elliott <[email protected]> * [anonymizer] Save trace in UI format (jaegertracing#2629) * Use fossa-contrib/fossa-action instead (jaegertracing#2571) * Use fossa-contrib/fossa-action instead Signed-off-by: Sora Morimoto <[email protected]> * Make step name clearer Signed-off-by: Sora Morimoto <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> * Update Makefile and Dockerfile for anonymizer (jaegertracing#2632) Signed-off-by: Ashmita Bohara <[email protected]> * Fix listen IP in unit test (jaegertracing#2636) Signed-off-by: zouyu <[email protected]> * Bump opentelemetry to v0.15.0 (jaegertracing#2634) * Bump opentelemetry to v0.15.0 Signed-off-by: Pavel Kositsyn <[email protected]> * add default value instead of nil value for jaegerreceiver config Signed-off-by: Pavel Kositsyn <[email protected]> * make lint Signed-off-by: Pavel Kositsyn <[email protected]> Co-authored-by: Kositsyn Pavel <[email protected]> Co-authored-by: Justin Hutchings <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]> Co-authored-by: Albert <[email protected]> Co-authored-by: Gary Brown <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Co-authored-by: Ashmita <[email protected]> Co-authored-by: Joe Elliott <[email protected]> Co-authored-by: Sora Morimoto <[email protected]> Co-authored-by: ZouYu <[email protected]> Co-authored-by: Kositsyn Pavel <[email protected]>

smorimoto requested a review from a team as a code owner October 15, 2020 20:51

smorimoto requested a review from joe-elliott October 15, 2020 20:51

mergify bot assigned jpkrohling Oct 15, 2020

mergify bot requested a review from jpkrohling October 15, 2020 20:51

smorimoto force-pushed the fossa-action branch 4 times, most recently from d34e3f2 to 79c0996 Compare October 15, 2020 21:29

smorimoto force-pushed the fossa-action branch 2 times, most recently from 1cbc70a to bdc6eef Compare October 15, 2020 21:44

Use fossa-contrib/fossa-action instead

4d89191

Signed-off-by: Sora Morimoto <[email protected]>

smorimoto force-pushed the fossa-action branch from bdc6eef to 4d89191 Compare October 15, 2020 21:50

Make step name clearer

3c241fe

Signed-off-by: Sora Morimoto <[email protected]>

yurishkuro reviewed Oct 15, 2020

View reviewed changes

jpkrohling reviewed Oct 27, 2020

View reviewed changes

Merge branch 'master' into fossa-action

cd90c16

yurishkuro merged commit f4d6968 into jaegertracing:master Nov 17, 2020

smorimoto deleted the fossa-action branch November 18, 2020 00:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use fossa-contrib/fossa-action instead #2571

Use fossa-contrib/fossa-action instead #2571

smorimoto commented Oct 15, 2020

codecov bot commented Oct 15, 2020 •

edited

Loading

yurishkuro Oct 15, 2020

smorimoto Oct 15, 2020

jpkrohling Oct 27, 2020

smorimoto Nov 5, 2020

yurishkuro Oct 15, 2020

smorimoto Oct 15, 2020

jpkrohling commented Oct 27, 2020

mergify bot commented Oct 27, 2020

jpkrohling left a comment

jpkrohling Oct 27, 2020

jpkrohling commented Nov 5, 2020

smorimoto commented Nov 5, 2020

yurishkuro commented Nov 17, 2020

Use fossa-contrib/fossa-action instead #2571

Use fossa-contrib/fossa-action instead #2571

Conversation

smorimoto commented Oct 15, 2020

Which problem is this PR solving?

Short description of the changes

codecov bot commented Oct 15, 2020 • edited Loading

Codecov Report

yurishkuro Oct 15, 2020

Choose a reason for hiding this comment

smorimoto Oct 15, 2020

Choose a reason for hiding this comment

jpkrohling Oct 27, 2020

Choose a reason for hiding this comment

smorimoto Nov 5, 2020

Choose a reason for hiding this comment

yurishkuro Oct 15, 2020

Choose a reason for hiding this comment

smorimoto Oct 15, 2020

Choose a reason for hiding this comment

jpkrohling commented Oct 27, 2020

mergify bot commented Oct 27, 2020

jpkrohling left a comment

Choose a reason for hiding this comment

jpkrohling Oct 27, 2020

Choose a reason for hiding this comment

jpkrohling commented Nov 5, 2020

smorimoto commented Nov 5, 2020

yurishkuro commented Nov 17, 2020

codecov bot commented Oct 15, 2020 •

edited

Loading