Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin elasticsearch-py to older version without elastic.co product check #3180

Merged
merged 3 commits into from
Aug 4, 2021

Conversation

pavolloffay
Copy link
Member

Updates #3179

@pavolloffay pavolloffay requested a review from a team as a code owner August 4, 2021 11:47
yurishkuro
yurishkuro previously approved these changes Aug 4, 2021
@yurishkuro yurishkuro enabled auto-merge (squash) August 4, 2021 11:52
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #3180 (93cb1bd) into master (2722ea8) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3180      +/-   ##
==========================================
+ Coverage   95.89%   95.95%   +0.05%     
==========================================
  Files         239      239              
  Lines       14649    14649              
==========================================
+ Hits        14048    14056       +8     
+ Misses        523      516       -7     
+ Partials       78       77       -1     
Impacted Files Coverage Δ
plugin/storage/integration/integration.go 79.28% <0.00%> (+0.39%) ⬆️
...lugin/sampling/strategystore/adaptive/processor.go 100.00% <0.00%> (+0.64%) ⬆️
cmd/query/app/server.go 95.58% <0.00%> (+1.47%) ⬆️
pkg/config/tlscfg/cert_watcher.go 94.73% <0.00%> (+2.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64aeccb...93cb1bd. Read the comment docs.

albertteoh
albertteoh previously approved these changes Aug 4, 2021
Signed-off-by: Pavol Loffay <[email protected]>
@pavolloffay
Copy link
Member Author

needs re-approval I had to push another commit

@yurishkuro yurishkuro merged commit 6eb9490 into jaegertracing:master Aug 4, 2021
@vprithvi vprithvi added this to the Release 1.25.0 milestone Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants