Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go.opentelemetry.io/proto/otlp from 0.7.0 to 0.12.0 #3527

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 14, 2022

Bumps go.opentelemetry.io/proto/otlp from 0.7.0 to 0.12.0.

Release notes

Sourced from go.opentelemetry.io/proto/otlp's releases.

Release v0.12.0

Generated Go code for the v0.12.0 version of the OTLP.

Release v0.11.0

Generated Go code for the v0.11.0 version of the OTLP.

Release v0.10.0

Generated Go code for the v0.10.0 version of the OTLP.

Release v0.9.0

Generated Go code for the v0.9.0 version of the OTLP.

Release v0.8.0

Generated Go code for the v0.8.0 version of the OTLP.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [go.opentelemetry.io/proto/otlp](https://github.com/open-telemetry/opentelemetry-proto-go) from 0.7.0 to 0.12.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-proto-go/releases)
- [Commits](open-telemetry/opentelemetry-proto-go@v0.7.0...v0.12.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/proto/otlp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner February 14, 2022 04:07
@dependabot dependabot bot requested a review from yurishkuro February 14, 2022 04:07
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #3527 (8ea69d4) into main (b3534f3) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3527      +/-   ##
==========================================
- Coverage   96.49%   96.47%   -0.02%     
==========================================
  Files         263      263              
  Lines       15376    15376              
==========================================
- Hits        14837    14834       -3     
- Misses        456      458       +2     
- Partials       83       84       +1     
Impacted Files Coverage Δ
cmd/query/app/static_handler.go 95.80% <0.00%> (-1.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3534f3...8ea69d4. Read the comment docs.

@yurishkuro
Copy link
Member

@albertteoh do you know what's happening here? The bot is removing otlp dependency altogether, it seems.

@albertteoh
Copy link
Contributor

@albertteoh do you know what's happening here? The bot is removing otlp dependency altogether, it seems.

This PR change is correct.

My bad. In #3525, I had initially generated the go files from proto but didn't know there was an extra sed in Makefiles, which resulted in the import.

I later fixed it in the subsequent commit but I didn't run go mod tidy afterwards.

@yurishkuro yurishkuro merged commit aa4c2e6 into main Feb 14, 2022
@dependabot dependabot bot deleted the dependabot/go_modules/go.opentelemetry.io/proto/otlp-0.12.0 branch February 14, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants