Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query for latency metrics #3559

Merged
merged 3 commits into from
Mar 2, 2022

Conversation

Ashmita152
Copy link
Contributor

Signed-off-by: Ashmita152 [email protected]

Which problem is this PR solving?

For aggregation, doing sum on latency_bucket metrics gives wrong data. We need to do sum over rate on latency_bucket

Prometheus histogram_quantile documentation also explains it.

Short description of the changes

We are replacing all sum() with sum(rate()) for latency metrics.

@Ashmita152 Ashmita152 requested a review from a team as a code owner March 2, 2022 04:59
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #3559 (314368d) into main (ab50903) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3559      +/-   ##
==========================================
+ Coverage   96.48%   96.50%   +0.01%     
==========================================
  Files         263      263              
  Lines       15376    15377       +1     
==========================================
+ Hits        14836    14839       +3     
+ Misses        456      455       -1     
+ Partials       84       83       -1     
Impacted Files Coverage Δ
plugin/metrics/prometheus/metricsstore/reader.go 100.00% <100.00%> (ø)
cmd/collector/app/server/zipkin.go 68.29% <0.00%> (-2.44%) ⬇️
cmd/query/app/static_handler.go 97.60% <0.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab50903...314368d. Read the comment docs.

Copy link
Contributor

@albertteoh albertteoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@albertteoh albertteoh enabled auto-merge (squash) March 2, 2022 09:45
@albertteoh albertteoh merged commit 7baadbd into jaegertracing:main Mar 2, 2022
albertteoh added a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
Signed-off-by: Ashmita152 <[email protected]>

Co-authored-by: Albert <[email protected]>
Signed-off-by: Albert Teoh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants