fix: exit on grpc plugin crash #3604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Würbach <[email protected]>
johanneswuerbach
force-pushed
the
grpc-plugin-health-check
branch
from
047d842
to
e592f13
Compare
Codecov Report
@@ Coverage Diff @@
## main #3604 +/- ##
==========================================
+ Coverage 96.50% 96.54% +0.04%
==========================================
Files 264 264
Lines 15447 15447
==========================================
+ Hits 14907 14914 +7
+ Misses 455 449 -6
+ Partials 85 84 -1
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Mar 29, 2022
albertteoh
pushed a commit
to albertteoh/jaeger
that referenced
this pull request
Jul 13, 2022
Signed-off-by: Johannes Würbach <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Albert Teoh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #3562
Short description of the changes
Exit when the grpc plugins fails so we an orchestration can recover from such failures. The exit inside the storage plugin feels odd, but I couldn't find a way to bubble up the failure to a different place.
Instead of crashing jaeger could also attempt to restart the plugin, but then restart loops would also need to be prevented, etc. so just crashing seemed easier and more obvious for an operator.
Related hashicorp/go-plugin#31 hashicorp/go-plugin#92