Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI flags for controlling HTTP server timeouts #4167

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • add 3 options to http-server CLI flags

@yurishkuro yurishkuro requested a review from a team as a code owner January 17, 2023 16:44
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Base: 97.10% // Head: 97.10% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c4925fb) compared to base (3bcac80).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4167   +/-   ##
=======================================
  Coverage   97.10%   97.10%           
=======================================
  Files         296      296           
  Lines       17493    17501    +8     
=======================================
+ Hits        16987    16995    +8     
  Misses        407      407           
  Partials       99       99           
Flag Coverage Δ
unittests 97.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/collector/app/flags/flags.go 100.00% <100.00%> (ø)
cmd/collector/app/server/http.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro yurishkuro merged commit 0237ca4 into jaegertracing:main Jan 17, 2023
@yurishkuro yurishkuro deleted the idle-timeout branch January 17, 2023 21:25
shubbham1215 pushed a commit to shubbham1215/jaeger that referenced this pull request Feb 22, 2023
## Which problem is this PR solving?
- Allows to control collector's HTTP server timeout settings: idle,
read, and read-header
- Resolves jaegertracing#4166

## Short description of the changes
- add 3 options to http-server CLI flags

Signed-off-by: Yuri Shkuro <[email protected]>
shubbham1215 pushed a commit to shubbham1215/jaeger that referenced this pull request Mar 5, 2023
## Which problem is this PR solving?
- Allows to control collector's HTTP server timeout settings: idle,
read, and read-header
- Resolves jaegertracing#4166

## Short description of the changes
- add 3 options to http-server CLI flags

Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: shubbham1215 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Jaeger-collector closes keepalive connection after 2 seconds due bug in net/http
2 participants