Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify ES config and factory #4396

Merged
merged 3 commits into from
Apr 19, 2023

Conversation

yurishkuro
Copy link
Member

The ClientBuilder interface was unnecessary, use Configuration struct directly

@yurishkuro yurishkuro requested a review from a team as a code owner April 19, 2023 03:10
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (6926438) 97.09% compared to head (c1345fc) 97.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4396      +/-   ##
==========================================
- Coverage   97.09%   97.08%   -0.02%     
==========================================
  Files         300      300              
  Lines       17729    17730       +1     
==========================================
- Hits        17214    17213       -1     
- Misses        414      416       +2     
  Partials      101      101              
Flag Coverage Δ
unittests 97.08% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugin/storage/es/factory.go 97.61% <100.00%> (+0.01%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro merged commit 82121e9 into jaegertracing:main Apr 19, 2023
@yurishkuro yurishkuro deleted the simplify-es-config branch April 19, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant