Feature: add goleak to check goroutine leak in tests

[akagami-harsh]

Which problem is this PR solving?

• Partially Fixes Enable and enforce goroutine leak checks in tests #5006

Description of the changes

• added a linter to check implementation of goleak in tests
• added go leak in some tests

How was this change tested?

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[akagami-harsh]

@yurishkuro, i have added goleak to some packages (that do not fail) and added a linter to verify goleak is present in tests. Could you please give me some pointers on whether I'm on the right track?

[yurishkuro]

Thanks, looks good as a direction.

[yurishkuro]

Let's fix the comments but not add any more packages, I prefer to merge smaller PRs.

[yurishkuro]

I simplified the script and moved goleak to lint target.

In the previous run some of the packages failed on goleak, so you need to remove them from this PR.

[yurishkuro]

we could also add goleak into all empty_test.go files, right now they do come up in the output

[akagami-harsh]

there are still some packages that do not fail, should i also add them

[yurishkuro]

let's do that in future PRs

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f63383) 95.61% compared to head (088a165) 95.62%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5010      +/-   ##
==========================================
+ Coverage   95.61%   95.62%   +0.01%     
==========================================
  Files         319      319              
  Lines       18786    18786              
==========================================
+ Hits        17963    17965       +2     
+ Misses        661      659       -2     
  Partials      162      162              

Flag	Coverage Δ
cassandra-3.x	25.63% <ø> (ø)
cassandra-4.x	25.63% <ø> (ø)
elasticsearch-5.x	19.90% <ø> (+0.01%)	⬆️
elasticsearch-6.x	19.90% <ø> (ø)
elasticsearch-7.x	20.04% <ø> (ø)
elasticsearch-8.x	20.13% <ø> (+0.01%)	⬆️
grpc-badger	19.52% <ø> (ø)
kafka	14.12% <ø> (ø)
opensearch-1.x	20.02% <ø> (ø)
opensearch-2.x	20.04% <ø> (ø)
unittests	93.37% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.