Remove support for Cassandra 3.x and add Cassandra 5.x #5962
Conversation
Signed-off-by: Mahad Zaryab <[email protected]>
| 5) | ||
| template=$(dirname $0)/v005.cql.tmpl | ||
| ;; |
There was a problem hiding this comment.
Do we want to drop schema creation for v3?
There was a problem hiding this comment.
These are not Cassandra versions but our db schema evolutions. Does something need to change for Cassandra v5?
There was a problem hiding this comment.
no i just copied the same file to maintain the separation - let me know if you want me to combine it
There was a problem hiding this comment.
If the db schema is not changing there's no need to create a new file.
There was a problem hiding this comment.
should i just use the v4 file then?
There was a problem hiding this comment.
Yes - schema version and Cassandra version are not coupled.
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5962 +/- ##
==========================================
+ Coverage 96.80% 96.82% +0.01%
==========================================
Files 345 345
Lines 16518 16518
==========================================
+ Hits 15991 15993 +2
+ Misses 340 339 -1
+ Partials 187 186 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mahadzaryab1
changed the title
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
| @@ -35,6 +35,9 @@ if [[ "$template" == "" ]]; then | |||
| 4) | |||
| template=$(dirname $0)/v004.cql.tmpl | |||
| ;; | |||
| 5) | |||
| template=$(dirname $0)/v004.cql.tmpl | |||
There was a problem hiding this comment.
I can see where the confusion about versions came about - but it's just a coincidence.
yurishkuro
added
the
changelog:breaking-change
yurishkuro
changed the title
|
I removed |
## Which problem is this PR solving? - Resolves jaegertracing/jaeger#5160 ## Description of the changes - In jaegertracing/jaeger#5962, we removed support for Cassandra 3.x. This PR updates the documentation to refelct that. ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test