Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace loopvar linter #5976

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Replace loopvar linter #5976

merged 1 commit into from
Sep 11, 2024

Conversation

anishbista60
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Changed the loopvar linter to copyloopvar.

How was this change tested?

Checklist

Signed-off-by: Anish Bista <[email protected]>
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (99f33a4) to head (fb4a720).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5976   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files         345      345           
  Lines       16523    16523           
=======================================
  Hits        15996    15996           
  Misses        340      340           
  Partials      187      187           
Flag Coverage Δ
badger_v1 8.02% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.75% <ø> (ø)
cassandra-5.x-v1 16.61% <ø> (ø)
cassandra-5.x-v2 1.75% <ø> (ø)
elasticsearch-6.x-v1 18.78% <ø> (ø)
elasticsearch-7.x-v1 18.84% <ø> (ø)
elasticsearch-8.x-v1 19.02% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v2 1.82% <ø> (+0.01%) ⬆️
grpc_v1 9.52% <ø> (ø)
grpc_v2 7.15% <ø> (ø)
kafka-v1 9.74% <ø> (ø)
kafka-v2 1.82% <ø> (ø)
memory_v2 1.82% <ø> (+0.01%) ⬆️
opensearch-1.x-v1 18.88% <ø> (ø)
opensearch-2.x-v1 18.88% <ø> (-0.02%) ⬇️
opensearch-2.x-v2 1.82% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:test Change that's adding missing tests or correcting existing tests label Sep 11, 2024
@yurishkuro yurishkuro merged commit d2d92c6 into jaegertracing:main Sep 11, 2024
49 of 50 checks passed
@yurishkuro
Copy link
Member

Thanks!

@yurishkuro yurishkuro added changelog:ci Change related to continuous integration / testing and removed changelog:test Change that's adding missing tests or correcting existing tests labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace loopvar linter
2 participants