Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/clarify extra prefixes behavior 97 #113

Merged
merged 14 commits into from
Jan 10, 2024

Conversation

jagerber48
Copy link
Owner

@jagerber48 jagerber48 commented Jan 10, 2024

Resolves #97

In the end this clarification ended up simply being the removal of

global_add_c_prefix
global_add_ppth_form
global_add_small_si_prefixes
global_reset_iec_prefixes
global_reset_parts_per_forms
global_reset_si_prefixes

and some additional documentation and tests making the expected behavior more clear.

@jagerber48 jagerber48 linked an issue Jan 10, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d3e09c9) 100.00% compared to head (bcc100b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #113   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         1110      1096   -14     
=========================================
- Hits          1110      1096   -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jagerber48 jagerber48 merged commit 3ff0f53 into main Jan 10, 2024
6 checks passed
@jagerber48 jagerber48 deleted the feature/clarify-extra-prefixes-behavior-97 branch January 10, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The behavior/semantics of extra prefixes may be confusing.
1 participant