fix(api): respondToAuthChallenge throws if missing ChallengeResponses

Correctly throws an InvalidParameterError instead of an UnsupportedError when ChallengeResponses is missing
jagregory · Nov 25, 2021 · 5e5aa36 · 5e5aa36
1 parent 6703ea9
commit 5e5aa36
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/src/targets/respondToAuthChallenge.test.ts b/src/targets/respondToAuthChallenge.test.ts
@@ -3,7 +3,11 @@ import jwt from "jsonwebtoken";
 import { ClockFake } from "../__tests__/clockFake";
 import { MockUserPoolClient } from "../__tests__/mockUserPoolClient";
 import { UUID } from "../__tests__/patterns";
-import { CodeMismatchError, NotAuthorizedError } from "../errors";
+import {
+  CodeMismatchError,
+  InvalidParameterError,
+  NotAuthorizedError,
+} from "../errors";
 import PublicKey from "../keys/cognitoLocal.public.json";
 import { CognitoClient } from "../services";
 import {
@@ -48,6 +52,19 @@ describe("RespondToAuthChallenge target", () => {
     ).rejects.toBeInstanceOf(NotAuthorizedError);
   });
 
+  it("throws if ChallengeResponses missing", async () => {
+    await expect(
+      respondToAuthChallenge({
+        ClientId: "clientId",
+        ChallengeName: "SMS_MFA",
+      })
+    ).rejects.toEqual(
+      new InvalidParameterError(
+        "Missing required parameter challenge responses"
+      )
+    );
+  });
+
   describe("when code matches", () => {
     it("generates tokens", async () => {
       MockUserPoolClient.getUserByUsername.mockResolvedValue({

diff --git a/src/targets/respondToAuthChallenge.ts b/src/targets/respondToAuthChallenge.ts
@@ -4,6 +4,7 @@ import {
 } from "aws-sdk/clients/cognitoidentityserviceprovider";
 import {
   CodeMismatchError,
+  InvalidParameterError,
   NotAuthorizedError,
   UnsupportedError,
 } from "../errors";
@@ -22,8 +23,8 @@ export const RespondToAuthChallenge = ({
   "cognitoClient" | "clock"
 >): RespondToAuthChallengeTarget => async (req) => {
   if (!req.ChallengeResponses) {
-    throw new UnsupportedError(
-      "RespondToAuthChallenge without ChallengeResponses"
+    throw new InvalidParameterError(
+      "Missing required parameter challenge responses"
     );
   }