fix(initiateAuth): invoke post auth lambda before generating tokens […

…281]

global.d.ts

@@ -0,0 +1 @@
+import "jest-extended";

jest.config.js

@@ -1,7 +1,10 @@
 module.exports = {
   roots: ["<rootDir>/src"],
   setupFiles: ["jest-date-mock"],
-  setupFilesAfterEnv: ["<rootDir>/setupTests.ts"],
+  setupFilesAfterEnv: [
+    "<rootDir>/setupTests.ts",
+    "jest-extended/all"
+  ],
   transform: {
     "^.+\\.ts$": "esbuild-jest",
   },

package.json

@@ -26,7 +26,7 @@
     "@babel/preset-typescript": "^7.16.0",
     "@commitlint/cli": "^15.0.0",
     "@commitlint/config-conventional": "^15.0.0",
-    "@jest/globals": "^27.0.6",
+    "@jest/globals": "^27.4.3",
     "@semantic-release/changelog": "^6.0.1",
     "@semantic-release/exec": "^6.0.3",
     "@semantic-release/git": "^10.0.1",
@@ -49,12 +49,13 @@
     "eslint-config-prettier": "^6.15.0",
     "husky": "^7.0.4",
     "jest": "^27.4.3",
+    "jest-extended": "^3.0.1",
     "jest-date-mock": "^1.0.8",
     "lint-staged": "^10.1.3",
     "markdown-toc": "^1.2.0",
     "nodemon": "^2.0.3",
     "prettier": "^2.5.1",
-    "semantic-release": "^18.0.1",
+    "semantic-release": "^19.0.3",
     "supertest": "^6.1.6",
     "ts-node": "^10.4.0",
     "typescript": "^4.5.2"

src/targets/initiateAuth.test.ts

@@ -444,7 +444,7 @@ describe("InitiateAuth target", () => {
         });
 
         describe("when Post Authentication trigger is enabled", () => {
-          it("invokes the trigger", async () => {
+          it("invokes the trigger before generating tokens", async () => {
             mockTokenGenerator.generate.mockResolvedValue({
               AccessToken: "access",
               IdToken: "id",
@@ -474,6 +474,10 @@ describe("InitiateAuth target", () => {
                 userPoolId: userPoolClient.UserPoolId,
               }
             );
+
+            expect(
+              mockTriggers.postAuthentication as jest.Mock
+            ).toHaveBeenCalledBefore(mockTokenGenerator.generate as jest.Mock);
           });
         });
       });

src/targets/initiateAuth.ts

@@ -189,15 +189,6 @@ const userPasswordAuthFlow = async (
     return verifyMfaChallenge(ctx, user, req, userPool, services);
   }
 
-  const result = verifyPasswordChallenge(
-    ctx,
-    user,
-    req,
-    userPool,
-    userPoolClient,
-    services
-  );
-
   if (services.triggers.enabled("PostAuthentication")) {
     await services.triggers.postAuthentication(ctx, {
       clientId: req.ClientId,
@@ -211,7 +202,14 @@ const userPasswordAuthFlow = async (
     });
   }
 
-  return result;
+  return verifyPasswordChallenge(
+    ctx,
+    user,
+    req,
+    userPool,
+    userPoolClient,
+    services
+  );
 };
 
 const refreshTokenAuthFlow = async (

tsconfig.json

@@ -9,6 +9,15 @@
     "strict": true,
     "target": "ES2019"
   },
-  "include": ["./setupTests.ts", "src/**/*.ts", "integration-tests/**/*.ts"],
-  "exclude": ["lib"]
+  "include": [
+    "./setupTests.ts",
+    "src/**/*.ts",
+    "integration-tests/**/*.ts"
+  ],
+  "exclude": [
+    "lib"
+  ],
+  "files": [
+    "global.d.ts"
+  ]
 }