refactor: the router is not a target, refactor out of the targets dir

[christhomas]

The Router is not a target. It's part of the server. So I moved it out of the targets and refactored all the imports

[jagregory]

Hey @christhomas, I like pulling the Router out of the targets. It definitely doesn't make sense to be in there. But I don't think the big Targets object should go with it, I'd prefer that stays in the targets directory, otherwise when people are adding new targets they will have to change something in server too which doesn't make sense to me (what changes together should stay together!).

Could you split that Router file to pull the Targets object out and back into the targets directory? That would make this perfect

[christhomas]

Ahhhh, that makes sense actually, I’ll do it, thanks

…

On 8. Feb 2022, 09:56 +0100, James Gregory ***@***.***>, wrote: Hey @christhomas, I like pulling the Router out of the targets. It definitely doesn't make sense to be in there. But I don't think the big Targets object should go with it, I'd prefer that stays in the targets directory, otherwise when people are adding new targets they will have to change something in server too which doesn't make sense to me (what changes together should stay together!). Could you split that Router file to pull the Targets object out and back into the targets directory? That would make this perfect — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.Message ID: ***@***.***>

[christhomas]

ok, I did this modification, take a look now

[christhomas]

hey dude, is this PR ok now? I have more interesting PR requests to make from my next branch :)

[jagregory]

Yeah looks great. Thanks for implementing my feedback.