-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid using collection as bean type in ManagedBeanTypesTest #477
Conversation
I would avoid But yes, this is a proper way to fix this test. |
impl/src/main/java/org/jboss/cdi/tck/tests/definition/bean/types/Gathering.java
Outdated
Show resolved
Hide resolved
Looks good, same remark about |
Alright, alright, my laziness got the better of me :) |
Do we treat this (or rather #476) as a challenge? EDIT: I mean, I don't have a problem with that, and I think we probably should, just asking for opinions. If we don't, this PR should wait for 4.1. |
It probably can't be a challenge, at least not the way it's worded right now. JDK 21 is obviously not a requirement for the EE 10 TCK. But just like an implementation detail was updated for the Authentication TCK that didn't effect the test goal itself (which is just testing generics in this case), it could be a general update. Thoughts? |
I am not sure we are allowed to put anything but necessary changes and challenge resolutions to 4.0.x releases now. |
I added the 4.1 milestone. Good point about branching @manovotn though. I want to submit the PR for TCK tests for |
Fixes #476
IIUIC, this should fix the problem while retaining the test goal (which is bean types for nested generics).
Is that right @arjantijms ?