Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix InvocationContextTest and InterceptorBindingInheritanceTest #497

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Nov 8, 2023

This is to cater for implementations that implement interception by proxying, in which case the contextual instance of a bean is an interception proxy, while InvocationContext.getTarget() returns the proxied object (an "actual" instance of the bean).

Stems from recent discussion in #468

This is to cater for implementations that implement interception by proxying,
in which case the contextual instance of a bean is an interception proxy,
while `InvocationContext.getTarget()` returns the proxied object (an "actual"
instance of the bean).
@Ladicek Ladicek added this to the CDI 4.1 milestone Nov 8, 2023
@Ladicek Ladicek requested a review from manovotn November 8, 2023 15:31
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I've also verified this test with latest Weld and it passes just fine.

@manovotn manovotn merged commit d78bfc7 into jakartaee:master Nov 28, 2023
4 checks passed
@Ladicek Ladicek deleted the proxy-based-interception-fix branch November 28, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants