Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial beans_4_0.xsd #517

Merged
merged 6 commits into from
Sep 8, 2021
Merged

Initial beans_4_0.xsd #517

merged 6 commits into from
Sep 8, 2021

Conversation

starksm64
Copy link
Contributor

Squash merge this as I could not squash it locally.

Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 2 minor suggestions.

Signed-off-by: Scott M Stark <[email protected]>
@starksm64 starksm64 merged commit 4093a5c into jakartaee:master Sep 8, 2021
@Ladicek
Copy link
Contributor

Ladicek commented Sep 8, 2021

I also suggested to fix the "this is the only configuration value read from a beans.xml file is the beans bean-discovery-mode attribute" malformed sentence, but that's a minor thing really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants