Move EE dependency version properties to parent pom #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott M Stark <[email protected]>
…e#786 - Set version to 4.1.0-SNAPSHOT Signed-off-by: Scott M Stark <[email protected]>
Ladicek
reviewed
Mar 4, 2024
| @@ -1,3 +1,6 @@ | |||
| <!-- | |||
| SPDX-License-Identifier: Apache-2.0 | |||
| --> | |||
There was a problem hiding this comment.
I see there's a YAML front matter below. This comment will make it not work. I'd suggest moving the comment into the front matter, using YAML comments:
---
# SPDX-License-Identifier: Apache-2.0
name: Bug report
about: Create a report to help us improve
title: ''
labels: ''
assignees: ''
---
...
That's what I did with the Jekyll templates in the docs directory.
|
Ok, I created a new PR with that change
…On Mon, Mar 4, 2024 at 2:03 AM Ladislav Thon ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/ISSUE_TEMPLATE/bug_report.md
<#787 (comment)>:
> @@ -1,3 +1,6 @@
+<!--
+ SPDX-License-Identifier: Apache-2.0
+-->
I see there's a YAML front matter below. This comment will make it *not*
work. I'd suggest moving the comment into the front matter, using YAML
comments:
---
# SPDX-License-Identifier: Apache-2.0
name: Bug report
about: Create a report to help us improve
title: ''
labels: ''
assignees: ''
---
...
That's what I did with the Jekyll templates in the docs directory.
—
Reply to this email directly, view it on GitHub
<#787 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACRDMW2SFN2EF3YRS73M7TYWQTFBAVCNFSM6AAAAABECDJ44KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMJTGU4TENJWGU>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #786 for the 4.1 branch