ContextService convenience methods for completion stages #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n stages Signed-off-by: Nathan Rauh <[email protected]>
mswatosh
approved these changes
Sep 8, 2021
nmittles
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #100
This pull copies over the method signatures from org.eclipse.microprofile.context.ThreadContext, except for withContextCapture because that is covered as a separate issue. I'm also updating doc to clarify that if the
user doesn't pass in a serializable instance in the first place, there should be no expectation that we make the
proxy serializable. Serializable isn't useful for completion stage actions, just adds overhead, and wasn't a
requirement of the equivalent methods in MicroProfile.
Signed-off-by: Nathan Rauh [email protected]