-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example tck-dist bundle build #184
Conversation
Signed-off-by: Scott M Stark <[email protected]>
Signed-off-by: Scott M Stark <[email protected]>
Signed-off-by: Scott M Stark <[email protected]>
@@ -0,0 +1,43 @@ | |||
Eclipse Foundation Technology Compatibility Kit License - v 1.0 | |||
Copyright (c) 2018, Eclipse Foundation, Inc. and its licensors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need the current year, 2022, as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to run the signature tests against the OpenLiberty compatible implementation still needs to be added to the CK user guide.
The TCK was using a different approach where it runs signature tests as part of all of the other tests, which is how they were running in Open Liberty, and in that case didn't need any additional instructions. I can see in this pull that you're getting us back to a more standard approach to the signature tests which will require adding the instructions as you point out and deleting the duplication, all of which can be a separate pull.
Signed-off-by: Scott M Stark <[email protected]>
I really like the use of the |
I like that approach. I would be in favor of opening a separate issue to get that done for the TCK in this same release and then be able to merge this pull to make other progress. |
Here is an example module that can be run after the TCK has been staged to create a dist bundle usable for the EE10 release. I have also added a signature map file and signature-generation profile to create it as I did not see this discussed in the TCK user guide. How to run the signature tests against the OpenLiberty compatible implementation still needs to be added to the CK user guide.