Add module-info.java file #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A junit test had to be deleted, since it imported things from outside the module. Since module-info.java has no test scope (like Maven does) this would import these dependencies for all clients of the API. There are options to add a second module-info just for testing, but they have their own problems, mostly wrt IDEs. Signed-off-by: Arjan Tijms <[email protected]>
aubi
reviewed
Jun 27, 2022
aubi
approved these changes
Jun 27, 2022
Ok ;) If someone wants to bring it back in some way, perhaps by creating a new module or so, it's still there in the history of course. |
njr-11
approved these changes
Jun 27, 2022
|
fixes #237 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A junit test had to be deleted, since it imported things from outside
the module.
Since module-info.java has no test scope (like Maven does) this would
import these dependencies for all clients of the API.
There are options to add a second module-info just for testing, but they
have their own problems, mostly wrt IDEs.
Signed-off-by: Arjan Tijms [email protected]