Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tests that are subject to Accepted TCK challenges #241

Merged
merged 1 commit into from
Jun 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@ target/
.idea
nb-configuration.xml
.DS_Store
.checkstyle
.checkstyle
api/.flattened-pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,11 @@ public void reset() {
* @assertion_ids: CONCURRENCY:JAVADOC:46
*
* @test_Strategy: Retrieve the next time that the task should run after.
* fix: https://github.com/jakartaee/concurrency/pull/222
* Accepted TCK challenge: https://github.com/jakartaee/concurrency/issues/228
* Can be reenabled in next release of Jakarta Concurrency
*/
@Test
@Test(enabled = false)
public void triggerGetNextRunTimeTest() throws Exception {
ScheduledFuture sf = TestUtil.getManagedScheduledExecutorService().schedule(new CounterRunnableTask(),
new CommonTriggers.TriggerFixedRate(new Date(), TestConstants.PollInterval.toMillis()));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ public void testAsynchronousMethodVoidReturnType() {
runTest(baseURL);
}

@Test
// TCK Accepted Challenge: https://github.com/jakartaee/concurrency/issues/224
@Test(enabled = false)
public void testCompletedFuture() {
runTest(baseURL);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,12 @@ protected String getServletPath() {
* @test_Strategy: login in a servlet with username "javajoe(in role manager)",
* then submit a task by ManagedExecutorService in which call a ejb that
* requires role manager.
*
* Accepted TCK challenge: https://github.com/jakartaee/concurrency/issues/227
* fix: https://github.com/jakartaee/concurrency/pull/218
* Can be reenabled in next release of Concurrency
*/
@Test
@Test(enabled = false)
public void managedExecutorServiceAPISecurityTest() {
runTest(baseURL);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ public void testAsynchronousMethodRunsWithContext() {
public void testAsynchronousMethodWithMaxAsync3() {
runTest(baseURL);
}

@Test
// Accepted TCK Challenge: https://github.com/jakartaee/concurrency/issues/224
@Test(enabled = false)
public void testCompletedFutureMSE() {
runTest(baseURL);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,12 @@ protected String getServletPath() {
* @test_Strategy: login in a servlet with username "javajoe(in role manager)",
* then submit a task by ManagedScheduledExecutorService in which call a ejb
* that requires role manager.
*
* Accepted TCK challenge: https://github.com/jakartaee/concurrency/issues/227
* fix: https://github.com/jakartaee/concurrency/pull/221
* Can be reenabled in the next release of Jakarta Concurrency
*/
@Test
@Test(enabled = false)
public void managedScheduledExecutorServiceAPISecurityTest() {
runTest(baseURL);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,14 @@ protected String getServletPath() {
return "ManagedThreadFactoryDefinitionServlet";
}

@Test
// Accepted TCK challenge: https://github.com/jakartaee/concurrency/issues/226
@Test(enabled = false)
public void testManagedThreadFactoryDefinitionAllAttributes() throws Throwable {
runTest(baseURL);
}

@Test
// Accepted TCK challenge: https://github.com/jakartaee/concurrency/issues/226
@Test(enabled = false)
public void testManagedThreadFactoryDefinitionAllAttributesEJB() throws Throwable {
URLBuilder requestURL = URLBuilder.get().withBaseURL(ejbContextURL).withPaths("ManagedThreadFactoryDefinitionOnEJBServlet").withTestName(testName);
runTest(requestURL);
Expand All @@ -101,12 +103,14 @@ public void testManagedThreadFactoryDefinitionDefaultsEJB() throws Throwable {
runTest(requestURL);
}

@Test
// Accepted TCK challenge: https://github.com/jakartaee/concurrency/issues/226
@Test(enabled = false)
public void testParallelStreamBackedByManagedThreadFactory() throws Throwable {
runTest(baseURL);
}

@Test
// Accepted TCK challenge: https://github.com/jakartaee/concurrency/issues/226
@Test(enabled = false)
public void testParallelStreamBackedByManagedThreadFactoryEJB() throws Throwable {
URLBuilder requestURL = URLBuilder.get().withBaseURL(ejbContextURL).withPaths("ManagedThreadFactoryDefinitionOnEJBServlet").withTestName(testName);
runTest(requestURL);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ public void testDeploymentDescriptorDefinesManagedScheduledExecutor() {
runTest(baseURL);
}

@Test
// Accepted TCK challenge: https://github.com/jakartaee/concurrency/issues/226
@Test(enabled = false)
public void testDeploymentDescriptorDefinesManagedThreadFactory() {
runTest(baseURL);
}
Expand Down