-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TCK JavaDoc #243
Fix TCK JavaDoc #243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Javadoc changes look good. I'm not sure why we would need to include Transaction as an API dependency. Perhaps others could chime in on that.
I think it is because it is referenced in the javadoc and now we use modules it is required. @aubi may have more info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is because it is referenced in the javadoc and now we use modules it is required. @aubi may have more info
It's actually API JavaDoc rather than TCK JavaDoc that references jakarta.transaction, and it's likely my fault from changes introduced in 3.0. In ContextServiceDefinition JavaDoc, it appears that I used {@link jakarta.transaction.UserTransaction}
rather than {@code jakarta.transaction.UserTransaction}
which is used in the JavaDoc of older code.
You might be able to avoid adding the dependency if you switch that reference.
@njr-11 in some of the other specifications we have indeed replaced (or reverted) to using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transaction requirement should be removed, and we should revert back to code
for the javadoc.
@njr-11 @arjantijms @KyleAure @smillidge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
Fix javadoc issues.