hint to request virtual threads #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Rauh <[email protected]>
mswatosh
requested changes
Oct 3, 2023
Thanks for spotting that. The copyright is corrected in 0e2c9eb |
mswatosh
approved these changes
Oct 4, 2023
This was referenced Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #268
This pull adds the virtual=true hint to request the use of virtual threads to ManagedThreadFactoryDefinition, ManagedExecutorDefinition, and ManagedScheduledExecutorDefinition. The default is false.
Regarding the discussion on the name of the attribute,
virtualis used because it matches the terminology and hard-coded method names of the java.lang.Thread API, which has methods like isVirtual and ofVirtual.