Invalid assertion in LastExecutionTests #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleAure
force-pushed
the
258-invalid-assertion
branch
from
d2b67ed
to
ed1bc23
Compare
KyleAure
force-pushed
the
258-invalid-assertion
branch
from
ed1bc23
to
ac7abcf
Compare
mswatosh
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #258
Removed
Wait.waitTillFutureIsDone()because it was misleading.Fixed the issues where it was being used incorrectly.
Everywhere else has been switched to
Wait.waitForTaskComplete()