Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors with asciidoc section headers #427

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Fix errors with asciidoc section headers #427

merged 1 commit into from
Feb 8, 2024

Conversation

njr-11
Copy link
Contributor

@njr-11 njr-11 commented Feb 6, 2024

Fix the following asciidoctor warnings that appear when building the spec doc:

[INFO] asciidoctor: WARN: jakarta-concurrency.adoc: line 2440: section title out of sequence: expected level 2, got level 4
[INFO] asciidoctor: WARN: jakarta-concurrency.adoc: line 2461: section title out of sequence: expected level 2, got level 4
[INFO] asciidoctor: WARN: jakarta-concurrency.adoc: line 2485: section title out of sequence: expected level 2, got level 4
[INFO] asciidoctor: WARN: jakarta-concurrency.adoc: line 2653: section title out of sequence: expected level 2, got level 3
[INFO] asciidoctor: WARN: jakarta-concurrency.adoc: line 2664: section title out of sequence: expected level 2, got level 3
[INFO] asciidoctor: WARN: jakarta-concurrency.adoc: line 2748: section title out of sequence: expected level 2, got level 3
[INFO] asciidoctor: WARN: jakarta-concurrency.adoc: line 2782: section title out of sequence: expected level 2, got level 3

@njr-11 njr-11 added this to the 3.1 milestone Feb 6, 2024
mswatosh
mswatosh approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@mswatosh mswatosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I confirmed that none of the modified sections are referenced in other places in the spec.

@njr-11 njr-11 merged commit 06f6bf7 into jakartaee:main Feb 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswatosh mswatosh mswatosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@njr-11 @mswatosh