Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify test counts in TCK documentation #484

Merged
merged 1 commit into from
May 2, 2024

Conversation

KyleAure
Copy link
Contributor

@KyleAure KyleAure commented May 1, 2024

As discussed here: jakartaee/specifications#733

The test counts in the TCK documentation were misleading:

  • Documented - [WARNING] Tests run: 268, Failures: 0, Errors: 0, Skipped: 27
  • Reality - [WARNING] Tests run: 295, Failures: 0, Errors: 0, Skipped: 27

I made the false assumption that the Tests Run did not include skipped tests, when in reality the skipped tests are double counted.

@KyleAure KyleAure added the EE11 Suggested changes for Jakarta EE 11 label May 1, 2024
@KyleAure KyleAure requested review from edbratt and njr-11 May 1, 2024 22:06
@KyleAure KyleAure self-assigned this May 1, 2024
Copy link

@edbratt edbratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So long as you have validated the test count, I'm happy. Thank you.

@KyleAure KyleAure merged commit f145b96 into jakartaee:main May 2, 2024
3 checks passed
@KyleAure KyleAure deleted the tck-test-count branch May 2, 2024 14:35
@KyleAure KyleAure mentioned this pull request May 2, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EE11 Suggested changes for Jakarta EE 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants