DeploymentDescriptorFull/WebTests Adds Resource Definitions with Qualifiers on a CDI Bean #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks fine and is nothing objectionable, but to confirm, do we need to hold up the 3.1 release for this? It will be the second time now that we have gone and prepared published TCK results for the component specification release review only to find that we need to redo everything all over again because of an update to the TCK, which also delays getting the spec to ballot. |
njr-11
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the same annotation as in #491
DeploymentDescriptorFull/WebTests are basically the same tests as AnnotationFull/WebTests, just requiring loading the definitions from xml files.