Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree structure support (API). #21

Closed
wants to merge 2 commits into from

Conversation

tomas-langer
Copy link
Contributor

Tree structure (API only).

Ignoring:

  • mutability
  • config source ordering

@tomas-langer tomas-langer self-assigned this Nov 18, 2021
@tomas-langer
Copy link
Contributor Author

There is some problem with builds - not using the latest commit. I will close this PR and open a new one.

@tomas-langer tomas-langer deleted the tree-structure branch November 18, 2021 14:51
@pzygielo
Copy link

There is some problem with builds - not using the latest commit. I will close this PR and open a new one.

I suppose it's because of
https://github.com/eclipse-ee4j/config/blob/eef980933a378b7121045ff93d51e297d345929b/.github/workflows/build.yml#L41

actions/checkout#299 has some references

The default of checkout action is to use the merge commit.
But with ref provided builds were started before new mergeability was determined, and old merge commit was used, I guess.
Perhaps this ref key could be dropped to avoid similar in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants