shipping all platform JARs as empty JARs

[lprimak]

Avoids duplicate class files and fixes OSGi and JPMS issues
fixes #133

[starksm64]

Look good to me. I did some basic compile testing of the generated empty jars and it works.

[lprimak]

Thanks! I just tested in my environment and it also works!
I think it's important enough to release 10.0.1 IMHO

[lprimak]

Time to merge (and release?)

[OndroMih]

I think this will break javadoc generation for Jakarta EE platform and profiles.

I assume that javadocs are generated with mvn javadoc:aggregate. If I run it before this PR, this goal runs everything until the compile phase, including glassfishbuild-maven-plugin:3.2.28:unpack-sources and maven-resources-plugin:2.4.3:copy-resources. Sources and resources from dependencies are used to generate the aggregate javadocs in target/site/apidocs. With this PR, this doesn't happen and aggregate Javadocs in target/site/apidocs are empty.

[OndroMih]

Instead of the changes in this PR, it should be enough to modify the parent pom with the following changes: OndroMih@9b56052

I tested it and all works - the platform JARs don't contain classes and running mvn javadoc:aggregate inside platform dir generates javadoc with all APIs.

[lprimak]

Can you make the PR then I can close mine?

[lprimak]

Or I can just port your changes into mine if you prefer

[lprimak]

I found an issue with javadoc, I will fix it and combine our solutions into a the existing PR

[lprimak]

@OndroMih I incorporated your changes, plus additional source dependencies for platform API javadocs so they include core and web APIs, just like they did in the past.

Let me know what you think, thank you!

[OndroMih]

Thanks, @lprimak. Now it looks good to me.

[Emily-Jiang]

Would this break the current apps that compile against the platform jars but now it is empty?

[lprimak]

Would this break the current apps that compile against the platform jars but now it is empty?

Absolutely not, since they will still have maven dependencies on the spec JARs.
The only way I can see anything breaking is if the umbrella JARs are manually copied and used on the CLASSPATH, i.e. copied from ~/.m2/repository/... into tomcat/lib or something similar.