Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jakarta.annotation.Nonnull should imply optional=false #614

Open
gavinking opened this issue Apr 20, 2024 · 0 comments · May be fixed by #656
Open

jakarta.annotation.Nonnull should imply optional=false #614

gavinking opened this issue Apr 20, 2024 · 0 comments · May be fixed by #656
Labels
candidate-for-4 Good candidate for JPA 4

Comments

@gavinking
Copy link
Contributor

We should allow:

@Nonnull
String name;

as an alternative to:

@Basic(optional = false)
String name;

and similarly for @ManyToOne and @OneToOne.
@gavinking gavinking added the candidate-for-4 Good candidate for JPA 4 label Apr 20, 2024
gavinking added a commit to gavinking/jpa-api that referenced this issue Sep 20, 2024
@gavinking
jakarta.annotation.Nonnull implies optional=false
36c435a 
see issue jakartaee#614

Signed-off-by: Gavin King <[email protected]>
@gavinking gavinking linked a pull request Sep 20, 2024 that will close this issue
Open
@gavinking gavinking linked a pull request Sep 20, 2024 that will close this issue
jakarta.annotation.Nonnull implies optional=false #656
Open
gavinking added a commit to gavinking/jpa-api that referenced this issue Sep 20, 2024
@gavinking
jakarta.annotation.Nonnull implies optional=false
6a4a183 
see issue jakartaee#614

Signed-off-by: Gavin King <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
candidate-for-4 Good candidate for JPA 4
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

jakarta.annotation.Nonnull implies optional=false gavinking/jpa-api
1 participant
@gavinking