Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tck-challege] Jakarta EE Core TCK's cdi-lite-tck-suite.xml out of sync with CDI's tck-tests.xml #1196

Closed
jamezp opened this issue Oct 13, 2023 · 3 comments · Fixed by #1195
Labels
accepted TCK challenge accepted challenge TCK challenge

Comments

@jamezp
Copy link
Contributor

jamezp commented Oct 13, 2023

Relevant Information

  1. The relevant specification version and section number(s).
    • Jakarta EE 10 Core Profile
  2. The coordinates of the challenged test(s).
    • jakarta.ee.tck.coreprofile:cdi-lite-tck-suite:10.0.1
  3. The exact TCK version.
    • 10.0.1
  4. The implementation being tested, including name and company.
    • WildFly by Red Hat
  5. A full description of why the test is invalid and what the correct behavior is believed to be.
    • There are 3 CDI tests that should be excluded from the Jakarta EE Core TCK's CDI Lite TCK that are not:
      • org.jboss.cdi.tck.tests.implementation.simple.lifecycle.SimpleBeanLifecycleTest
      • org.jboss.cdi.tck.tests.context.DestroyForSameCreationalContextTest
      • org.jboss.cdi.tck.tests.definition.bean.types.ManagedBeanTypesTest
  6. Any supporting material; debug logs, test output (.jtr file), test logs, run scripts, etc.

The cdi-lite-tck-suite.xml is out of sync with CDI's tck-tests.xml. These tests should be excluded in the cdi-lite-tck-suite.xml:

<!-- https://github.com/jakartaee/cdi-tck/issues/453 -->
<class name="org.jboss.cdi.tck.tests.implementation.simple.lifecycle.SimpleBeanLifecycleTest">
    <methods>
        <exclude name="testCreateReturnsSameBeanPushed"/>
    </methods>
</class>
<class name="org.jboss.cdi.tck.tests.context.DestroyForSameCreationalContextTest">
    <methods>
        <exclude name="testDestroyForSameCreationalContextOnly"/>
    </methods>
</class>

<!-- https://github.com/jakartaee/cdi-tck/issues/485 -->
<class name="org.jboss.cdi.tck.tests.definition.bean.types.ManagedBeanTypesTest">
    <methods>
        <exclude name=".*"/>
    </methods>
</class>

The latter (org.jboss.cdi.tck.tests.definition.bean.types.ManagedBeanTypesTest) causes issues with the TCK passing on Java 21.

If we cannot get this merged and a new Jakarta EE 10 Core Profile TCK released, we're asking that we can explicitly exclude these tests in our test configuration. In our case it will be on the maven-surefire-plugin section of our pom.xml for the CDI Lite TCK tests.

Additional context
The CDI TCK Challenge issues:

@jamezp
Copy link
Contributor Author

jamezp commented Oct 13, 2023

I seem to be wrong about being able to use excludes in the maven-surefire-plugin as the tests use TestNG and the suiteXmlFiles configuration parameter. With that set, the excludes are ignored. We'd need to modify the cdi-lite-tck-suite.xml to get this working. This is definitely possible, but a new release of the Jakarta EE 10 Core Profile would be preferred.

@scottmarlow
Copy link
Contributor

Thanks @jamezp

@scottmarlow
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted TCK challenge accepted challenge TCK challenge
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants