Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to generate and move parameterized source into the source modules #1349

Closed
Tracked by #1126
starksm64 opened this issue Jul 9, 2024 · 3 comments · Fixed by #1361 or #1456
Closed
Tracked by #1126

Need to generate and move parameterized source into the source modules #1349

starksm64 opened this issue Jul 9, 2024 · 3 comments · Fixed by #1361 or #1456
Assignees
Milestone

Comments

@starksm64
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The tckrefactor branch has vehicle related test classes that are processed as templates to generate source in the test package, and then compiled, bunded into test artifact, and then deleted. This does not work with modern test frameworks that expect all source to be in the test packages.

Describe the solution you'd like
All of the paramterized test source and descriptors need to be placed into the java and resource paths of the testsuite.

Additional context
Currently identified classes and descriptors include:
common/src/main/java/com/sun/ts/tests/common/vehicle/ejbliteservlet2/ejbliteservlet2_vehicle_web.xml
common/src/main/java/com/sun/ts/tests/common/vehicle/ejbliteservlet2/EJBLiteServlet2Filter.java.txt
common/src/main/java/com/sun/ts/tests/common/vehicle/ejblitejsp/EJBLiteJSPTag.java.txt
common/src/main/java/com/sun/ts/tests/common/vehicle/ejblitesecuredjsp/ejblitesecuredjsp.tld
common/src/main/java/com/sun/ts/tests/common/vehicle/ejblitesecuredjsp/EJBLiteSecuredJSPTag.java.txt
common/src/main/java/com/sun/ts/tests/common/vehicle/ejbliteservlet/ejbliteservlet_vehicle_web.xml
common/src/main/java/com/sun/ts/tests/common/vehicle/ejbliteservlet/EJBLiteServletVehicle.java.txt
common/src/main/java/com/sun/ts/tests/common/vehicle/ejbliteservlet/HttpServletDelegate.java.txt
common/src/main/java/com/sun/ts/tests/common/vehicle/ejbliteservletcal/ejbliteservletcal_vehicle_web.xml
common/src/main/java/com/sun/ts/tests/common/vehicle/ejbliteservletcal/EJBLiteServletContextAttributeListener.java.txt

I think @scottmarlow has identified other areas that are doing build time transformations of template files as well.

@scottmarlow
Copy link
Contributor

https://gist.github.com/scottmarlow/fc5c8be4fb4b69b50bfb1423218b8c5d contains the list of various files that contain @...@ parameters that are resolved via ant scripting. We will not use Ant scripting in EE 11 so the other template files not addressed by the pull request need to be addressed (note that the list should be updated after removing optional specification tests).

@starksm64
Copy link
Contributor Author

I added your comment to the #1361 issue that is about dealing with the other template files.

starksm64 added a commit to jakartaredhat/platform-tck-refactor that referenced this issue Jul 14, 2024
@starksm64 starksm64 reopened this Aug 15, 2024
@starksm64
Copy link
Contributor Author

These tld files still need to be done:
common/src/main/java/com/sun/ts/tests/common/vehicle/ejblitejsp/ejblitejsp.tld
common/src/main/java/com/sun/ts/tests/common/vehicle/ejblitesecuredjsp/ejblitesecuredjsp.tld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants