-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSP TCK Refactoring using Arquillian and JUnit #1182
JSP TCK Refactoring using Arquillian and JUnit #1182
Conversation
- duplicated SunRIURL class to jsp module - copied ArrayELResolverTest.jsp, WEB-INF/arrayelresolver.tld from webartifacts module
jsp/src/main/java/com/sun/ts/tests/jsp/common/client/AbstractUrlClient.java
Outdated
Show resolved
Hide resolved
: copied the web.xml from src, copied other web resources(tld, tag, tagx, gf, jsp, jspx, html files) from webartifacts/jsp module
- pending 37 tests after this change to be run - URLClient classes renamed to URLClientIT
@markt-asf @stuartwdouglas like other TCK rewriting, the JSP TCK rewrite is going to be too big to review. IMO, when we have time to try running different implementations against rewritten TCKs, we will better be able to review the new TCKs. Having said that, your feedback is welcome on this pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changes looks good to me, I have added minor comments for future maintainability.
jsp/src/main/java/com/sun/ts/tests/jsp/api/jakarta_el/beanelresolver/URLClient.java
Show resolved
Hide resolved
jsp/src/main/java/com/sun/ts/tests/jsp/api/jakarta_el/createvalexpr/URLClientIT.java
Show resolved
Hide resolved
jsp/src/main/java/com/sun/ts/tests/jsp/api/jakarta_el/mapelresolver/URLClientIT.java
Outdated
Show resolved
Hide resolved
.../main/java/com/sun/ts/tests/jsp/api/jakarta_servlet/jsp/el/elparseexception/URLClientIT.java
Outdated
Show resolved
Hide resolved
jsp/src/main/java/com/sun/ts/tests/jsp/api/jakarta_servlet/jsp/el/expression/URLClientIT.java
Outdated
Show resolved
Hide resolved
Maybe these things can (should?) move to the base class of the IT tests? @BeforeEach
void logStartTest(TestInfo testInfo) {
logger.log(Logger.Level.INFO, "STARTING TEST : "+testInfo.getDisplayName());
}
@AfterEach
void logFinishTest(TestInfo testInfo) {
logger.log(Logger.Level.INFO, "FINISHED TEST : "+testInfo.getDisplayName());
} |
...in/java/com/sun/ts/tests/jsp/api/jakarta_servlet/jsp/tagext/tagvariableinfo/URLClientIT.java
Outdated
Show resolved
Hide resolved
@arjantijms @olamy I have added the changes to use host/port from Arquillian only in latest commit. If no other comments I will merge this PR by tomorrow. @dmatej I re-requested review by mistake. Please ignore. |
Related Issue(s)
#1126
Describe the change
Pending items :