-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCK Challenge: JAXRSClientIT#closeTest fixes #1196
Comments
jbescos
added a commit
to jbescos/rest
that referenced
this issue
Nov 29, 2023
Signed-off-by: Jorge Bescos Gascon <[email protected]>
This was referenced Nov 29, 2023
jbescos
changed the title
TCK Challenge: RepeatedCasterResource#send fixes
TCK Challenge: JAXRSClientIT#closeTest fixes
Nov 29, 2023
jbescos
added a commit
to jbescos/rest
that referenced
this issue
Nov 29, 2023
Signed-off-by: Jorge Bescos Gascon <[email protected]>
jbescos
added a commit
to jbescos/rest
that referenced
this issue
Dec 1, 2023
Signed-off-by: Jorge Bescos Gascon <[email protected]>
jbescos
added a commit
to jbescos/rest
that referenced
this issue
Dec 5, 2023
Signed-off-by: Jorge Bescos Gascon <[email protected]>
jbescos
added a commit
to jbescos/rest
that referenced
this issue
Dec 5, 2023
Signed-off-by: Jorge Bescos Gascon <[email protected]>
jbescos
added a commit
to jbescos/rest
that referenced
this issue
Dec 5, 2023
Signed-off-by: Jorge Bescos Gascon <[email protected]>
This was referenced Dec 5, 2023
Rejecting this. There are some fixes that I will do in Helidon and in Jersey. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This method in
RepeatedCasterResource
:The line
sink.send(sse.newEvent(String.valueOf(cnt++)));
can throw exception, at least in Jersey:https://github.com/eclipse-ee4j/jersey/blob/d8458a64cb26568ab6bdbf4ac57c2f7b4d774f77/core-server/src/main/java/org/glassfish/jersey/server/ChunkedOutput.java#L300
When that happens, the exception is not caught and the variable
isOpen
is not correctly updated.I suggest to catch it. I am going to create a PR to show it.
There is also a possible ConcurrentModificationException in
JAXRSClientIT#closeTest
in line 636:holder
is iterated and it could be receiving an event during that time.@jansupol to check whether my request makes sense.
PR: #1197
Exception:
The text was updated successfully, but these errors were encountered: