Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature test to Servlet TCK #589

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

markt-asf
Copy link
Contributor

Machinery copied from EL with some code clean up (warnings fixed, unused code removed, added generics).
Tested with Tomcat that has it's own Servlet API JAR and found a Tomcat bug that has since been fixed.

Machinery copied from EL with some code clean up (warnings fixed, unused
code removed, added generics).
Tested with Tomcat that has it's own Servlet API JAR and found a Tomcat
bug that has since been fixed.
@olamy
Copy link
Contributor

olamy commented Mar 22, 2024

@markt-asf LGTM but you need to change the file .github/workflows/maven.yml to use jdk17.

diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
index fc541a5..6c3ca89 100644
--- a/.github/workflows/maven.yml
+++ b/.github/workflows/maven.yml
@@ -8,11 +8,13 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v1
-    - name: Set up JDK 11
-      uses: actions/setup-java@v1
+    - uses: actions/checkout@v4
+    - name: Set up JDK 17
+      uses: actions/setup-java@v3
       with:
-        java-version: 11
+        java-version: 17
+        distribution: temurin
+        cache: 'maven'
     - name: Set up Maven
       run:
         mvn --errors --batch-mode --show-version org.apache.maven.plugins:maven-wrapper-plugin:3.2.0:wrapper "-Dmaven=3.9.4"

I will propose to use dependabot in another PR to have some auto PRs to upgrade this.

@markt-asf
Copy link
Contributor Author

Tx for the review. I'll make that change and then merge.

@markt-asf markt-asf merged commit 47d5094 into jakartaee:master Mar 22, 2024
2 checks passed
@markt-asf markt-asf deleted the tck-add-sig-test branch March 22, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants