Adds package-lock.json to .gitignore
#35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going through the [service worker course on udemy](https://classroom.udacity.com/courses/ud899) and running `npm install` generates a `package.json` file thereby automatically creating a diff. May confuse newb users when they run `npm reset --hard` as there is still a diff.
|
@jakearchibald would love to get this merged. Helpful for engineers who are just getting started w/ offline-first courses. :) |
|
@jakearchibald bump :) normally this isn't that big of a deal but it does create confusion for newb devs who may not understand why there's a diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going through the service worker course on udacity and running
npm installgenerates apackage.jsonfile thereby automatically creating a diff. May confuse newb users when they runnpm reset --hardas there is still a diff.