Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional Cloudfront invalidation step at the end #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jgarth
Copy link

@jgarth jgarth commented May 14, 2020

If $AWS_CF_DISTRIBUTION_ID is set, a Cloudfront invalidation request will
be created for paths /*. Useful when hosting websites with S3 + Cloudfront.

If AWS_CF_DISTRIBUTION_ID is set, a CloudFront invalidation request will
be created for path `/*`. Useful when hosting websites with S3 + CF.
@sergeyzwezdin
Copy link

@jgarth It would be useful to validate not /*, but objects that were really changed.

@JustFly1984
Copy link

That could be a really useful feature, but it could be optional.
Currently we have issues with implementing 100% bulletproof CSP with nonce, and it happens that Cloudfront do not have functionality to inject nonce to all script and style tags in html served, so we are thinking about other solutions that provides desired CSP nonce security. if somebody have non-PHP solutions, please share with me.

@dkadrios
Copy link

dkadrios commented Jun 8, 2021

In addition to AWS_CF_DISTRIBUTION_ID, what if INVALIDATE_PATHS was also added? Perhaps 'index.html' could be a suitable default value.

Currently, I'm getting by with https://github.com/chetan/invalidate-cloudfront-action but it sure would be great to have everything under one roof, so to speak.

Copy link

@peter-mxtoolbox peter-mxtoolbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be awesome.

@michaellyons
Copy link

@jakejarvis Any potential for getting this evaluated/merged?

@jeanhdev
Copy link

Any update on this? Could be really helpful!

kgoettler added a commit to kgoettler/s3-sync-action that referenced this pull request Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants