Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies; change license to MIT, remove support for lower versions of jQuery, add GH templates #361

Merged
merged 3 commits into from
Feb 17, 2024

Conversation

jakerella
Copy link
Owner

@jakerella jakerella commented Feb 11, 2024

What is the problem being solved?

Please describe the problem being solved. You can reference an existing Issue versus rewriting it here!

  • We have ton of very old dependencies and in some cases they were maintained statically versus using npm.
  • The license does not need to be dual considering MIT is so permissive
  • IE 11 is no longer supported by Microsoft
  • Older versions of jQuery just cause headaches in testing and are not widely in use (and should not be)
  • We need better templates for how to contribute and support this project

This PR will resolve issues: #331 #343 #344 #360

How have you solved the problem?

Please describe your approach to solving the problem. Don't repeat the changes in the file diff, just focus on the high-level approach!

  • CHANGES THE LICENSE to only support MIT. This should be the most permissive possible and thus not be an issue.
  • Removes support for Internet Explorer (about time)
  • Removes support for lower versions of jQuery (now we only support the latest patch in each major branch: 1.x, 2.x, 3.x)
  • Removes support for RequireJS as it is no longer in active development
  • Moved a bunch of static dependencies into the package.json and referenced them properly
  • Removed TravisCI. I'll try to add in GH actions instead to run the browserstack tests on PR
  • Adds GH templates for bug reports, feature requests, questions, and pull requests
  • Adds a GH security policy
  • Updates many very old dependencies

NOTE There are zero changes to the source code in this PR, and thus a new release will NOT be issued. However, because I updated a bunch of dependencies, the way in which the minified file is generated changed. As such, you should test your stuff if you use the .min version.

How can someone test that the problem was solved?

Since there were no changes to source code, the biggest thing to test is that the tests run as expected.

  • I have run the unit tests locally
  • I have tested this change with all supported versions of jQuery
  • I have tested this change on at least 2 browsers

@jakerella jakerella changed the title Update license, remove support for lower versions of jQuery, add GH templates Update dependencies; change license to MIT, remove support for lower versions of jQuery, add GH templates Feb 17, 2024
@jakerella jakerella merged commit 4ca7ace into master Feb 17, 2024
@jakerella jakerella deleted the test-and-doc-updates branch February 17, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant