-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to bevy 0.14 #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can do this (wanted to make a suggestion but I can't suggest over non-changed lines): fn with_main_world_in_render_app<T>(app: &mut App, f: impl Fn(&mut SubApp) -> T) -> T {
// temporarily add the app world to the render world as a resource
let inserted_world = std::mem::take(app.world_mut());
let mut render_main_world = bevy_render::MainWorld::default();
*render_main_world = inserted_world;
let render_app = app.sub_app_mut(RenderApp);
render_app.world_mut().insert_resource(render_main_world);
let ret = f(render_app);
// move the app world back, as if nothing happened.
let mut inserted_world = render_app
.world_mut()
.remove_resource::<bevy_render::MainWorld>()
.unwrap();
*app.world_mut() = std::mem::take(&mut *inserted_world);
ret
} |
Co-authored-by: Kristoffer Søholm <[email protected]>
5 tasks
I think something is wrong here, running
|
actually never mind that, looking through the code I don't see what would cause this, and it seems my setup is broken on main as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how to fix the "generate_docs" examples, which swaps out and in the
App::world
, which is now behind getter/setters.