-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix builds #336
Comments
I can fix it... Point me to your build problem. I just fixed this for a large range of my own projects. Update: I found your CI/ system. The most intractable problem you currently have is the same one I'm struggling to overcome:
This completely breaks just over 100+ private projects' CI/CD systems and over 90,000 public installs of my This v2.2.0 of composer really broke a lot of stuff!! It should be v3.0.0 for all the backward incompatibilities... |
thanks! It might be a problem with the way composer-bin-plugin or composer itself creates symlinks. I haven’t looked at it too deep yet. If there’s anything to change on our side it will probably be in the jakzal/toolbox repo (see failing builds there). the problem with allowed-plugins isn’t critical until next year. |
This is simply a warning and it should not break any builds. We explicitly built this in with a grace period of six months so that we do not disrupt anything and give people time to update their composer.json files. That said yes please do fix it before it becomes a problem. It only requires you to list the plugins like
Yes that's more or less what it is, see composer/composer#10402 for an explanation and a way to fix. I'd be curious to get feedback from people encountering issues. I couldn't find exactly the source of |
Thanks @Seldaek. It seems we're having issues with links to composer created scripts in combination with composer-bin-plugin. i.e. This works fine:
This doesn't:
composer 2.2.2 |
Actually, it's unrelated to composer-bin-plugin:
|
…tespace or whitespace between shebang and <?php, refs jakzal/phpqa#336
OK I see. So there is one bug here in that we do not detect https://github.com/akeneo/php-coupling-detector/blob/master/bin/php-coupling-detector as a php file I believe because it has a blank line before But the other issue is that the symlinking you are doing is going to break the bin proxies we now create as of Composer 2.2, so if any tool you are using has a binary which is a shell script and not PHP, this will still break. The issue is the symlink changes the resolution of
Then when calling If you however call it via a symlink I am not sure if that one is a solvable problem on our end or not, will need to investigate further. |
Should be fixed by composer/composer@390260c actually.. so hopefully now with latest snapshot ( |
Thanks @Seldaek 🍺 you're a ⭐ Problem solved! |
I'll update jakzal/toolbox as soon as a new composer version is released. As for allow-plugins: jakzal/toolbox#415 |
2.2.3 is out now |
Once there's a solution to composer/composer#10389
The text was updated successfully, but these errors were encountered: