Support Bangla Language #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jama5262
reviewed
Mar 22, 2021
test/jiffy_relative_locale_test.dart
Outdated
Comment on lines
448
to
466
| test( | ||
| 'test Jiffy.locale() method with parsing bn locale should return correct date time in bn locale', | ||
| () async { | ||
| var locale = await Jiffy.locale('bn'); | ||
| expect(jiffy1.fromNow(), 'কিছু মুহূর্ত আগে'); | ||
| expect(jiffy2.fromNow(), 'কিছু মুহূর্ত পরে'); | ||
| expect(jiffy3.fromNow(), 'এক মিনিট আগে'); | ||
| expect(jiffy5.fromNow(), '১০ মিনিট আগে'); | ||
| expect(jiffy6.fromNow(), 'এক ঘন্টা আগে'); | ||
| expect(jiffy7.fromNow(), '১০ ঘণ্টা আগে'); | ||
| expect(jiffy8.fromNow(), 'এক দিন আগে'); | ||
| expect(jiffy9.fromNow(), '১০ দিন আগে'); | ||
| expect(jiffy10.from(Jiffy('2019-10-01')), 'এক মাস আগে'); | ||
| expect(jiffy11.fromNow(), '১০ মাস আগে'); | ||
| expect(jiffy12.fromNow(), 'এক বছর আগে'); | ||
| expect(jiffy13.fromNow(), '১০ বছর আগে'); | ||
| expect(locale.startOfWeek(), StartOfWeek.SUNDAY); | ||
| expect(locale.ordinals(), null); | ||
| }); |
There was a problem hiding this comment.
Please move this test in its group, not outside
lib/src/locale/bnLocale.dart
Outdated
| @override | ||
| String aboutAMinute(int minutes) => 'এক মিনিট'; | ||
| @override | ||
| String minutes(int minutes) => '$minutes মিনিট'; |
There was a problem hiding this comment.
I see you've added bn locale to the lib/src/utils/replace.dart file to replace all number characters but was never used. Please see the suggested edit example
Suggested change
| String minutes(int minutes) => '$minutes মিনিট'; | |
| String minutes(int minutes) => replaceToLocaleNum('$minutes মিনিট', 'bn'); |
jama5262
requested changes
Apr 20, 2021
jama5262
requested changes
Apr 30, 2021
test/jiffy_relative_locale_test.dart
Outdated
| expect(jiffy7.fromNow(), '১০ ঘন্টা আগে'); | ||
| expect(jiffy8.fromNow(), 'এক দিন আগে'); | ||
| expect(jiffy9.fromNow(), '১০ দিন আগে'); | ||
| expect(jiffy10.from(Jiffy('2019-10-01')), 'এক মাস আগে'); |
There was a problem hiding this comment.
Suggested change
| expect(jiffy10.from(Jiffy('2019-10-01')), 'এক মাস আগে'); | |
| expect(jiffy10.from(Jiffy('2019-10-01', 'yyyy-MM-dd')), 'এক মাস আগে'); | |
| // or | |
| expect(jiffy10.from(Jiffy([2019, 10, 1])), 'এক মাস আগে'); |
jama5262
requested changes
May 3, 2021
Codecov Report
@@ Coverage Diff @@
## develop #102 +/- ##
===========================================
+ Coverage 93.44% 93.59% +0.14%
===========================================
Files 31 32 +1
Lines 1266 1295 +29
===========================================
+ Hits 1183 1212 +29
Misses 83 83
Continue to review full report at Codecov.
|
jama5262
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.