Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Norwegian Bokmål (nb) language #63

Merged
merged 13 commits into from
May 2, 2020

Conversation

zeusbaba
Copy link
Contributor

No description provided.

@jama5262
Copy link
Owner

@zeusbaba Hi, thanks for your contribution. A few changes I would request

  1. Please send PRs to develop branch and not the master branch
  2. Write tests for your locale

@jama5262 jama5262 requested review from jama5262 and removed request for jama5262 April 30, 2020 09:57
@zeusbaba zeusbaba changed the base branch from master to develop April 30, 2020 10:40
@zeusbaba
Copy link
Contributor Author

fyi. just updated with tests and base branch.

@jama5262
Copy link
Owner

jama5262 commented May 1, 2020

@zeusbaba Thanks but the travis CI test failed because of not formating your code, please use dart-formater for all the files you added or changed. Dart formatting is required so that the tests could pass

Use this to check for any none formatted files

dartanalyzer lib test example && dartfmt -n --set-exit-if-changed lib test

@zeusbaba
Copy link
Contributor Author

zeusbaba commented May 1, 2020

thanks for your feedback. I'll do that soon together with a fix.
btw I just realized that there's another #61 for Norwegian language, apologies i missed that.

@zeusbaba zeusbaba changed the title added Norwegian (no, no-nb) language added Norwegian Bokmål (nb) language May 1, 2020
@jama5262 jama5262 merged commit 05cc231 into jama5262:develop May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants