-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safety async completions (unhook events, cancel task completion sources, etc) & Add CancellationTokens #604
Conversation
@Redth FYI - this is a more complete fix for you. Yes... you need to add cancellation tokens like a good dev though I've included defaults on the CTs for those who want to play roulette |
Kill off #601 |
Looks like will need a little code changes in this to build |
Ya I'll fix everything up with the samples. I wanted to make sure you were fine with the breaking changes that are incoming first. |
go for it and i will bump numbers, also please update docs if possible ;) |
Also, i am fine at this point dropping xamarin tfms and also bumping to require .net 8 |
.NET 8 is done-ish. There isn't enough setup for testing. I elect @Redth :) Also, I did docs... so someone owes me a beer |
who needs tests?!??!1 we do it live! |
going to setup the ci now for .net 8 |
And we are green! @Redth you can download the nugets to give it a try from DevOps |
64da866
into
jamesmontemagno:dotnet8
Please take a moment to fill out the following:
There are ways where iOS can get itself into trouble and get into a "stuck" state without any workaround. By adding cancellation tokens, users can get themselves out of trouble (ie. app is backgrounding, cancel task) which will release any events that are pinned as well as cancel out the task completion sources.
Fixes # .
Changes Proposed in this pull request:
I have not updated the samples or any docs. This is a proposal and does have breaking changes. I also only test in production 👍